Fix failing lint #329
Merged
Fix failing lint #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/no-gh-lint
branch
from
3d63291 to
4fe0cce
Compare
Pylint 3.3.0 includes a new warning: too-many-positional-arguments [1]. We already ignore a similar too-many-arguments warning in several places since "fixing" it is backward-incompatible. 1. pylint-dev/pylint#9099
Disabling any new pylint warnings per-entity results in older pylint failing due to unknown option. Since we support several pylint versions due to Python version restrictions, we need to support multiple pylint versions as well.
Any new linter release, including bugfix ones, may result in failing CI. Since tarantool-python CI is included in several integration pipelines, such things may block work on repos like tarantool/tarantool and tarantool/luajit. On the other hand, if CI will start to fail due to a new linter release, it is unlikely that something user-critical will be discovered. So for now let's stick to the following approach: one will bump linters manually from time to time and fix/disable emerging issues.
DifferentialOrange
force-pushed
the
DifferentialOrange/no-gh-lint
branch
from
4fe0cce to
7726a91
Compare
oleg-jukovec
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for more info.